-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Add nullable dtypes to read_csv #40687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 9 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
148fc9d
Add nullable dtypes to read_csv
lithomas1 053ecd7
Merge branch 'master' into use-nullable-csv
lithomas1 a70f3a4
Updates
lithomas1 1726c29
Merge branch 'use-nullable-csv' of github-other.com:lithomas1/pandas …
lithomas1 2504be6
More thorough testing
lithomas1 89f4032
Merge branch 'master' of https://github.com/pandas-dev/pandas into us…
lithomas1 63733dc
Optimizations & Found a bug!
lithomas1 ea63fb2
Merge branch 'master' of https://github.com/pandas-dev/pandas into us…
lithomas1 738c340
Merge branch 'master' into use-nullable-csv
lithomas1 8baf120
WIP
lithomas1 c822fc6
Merge branch 'use-nullable-csv' of github-other.com:lithomas1/pandas …
lithomas1 c3ee883
float support working
lithomas1 d135dbb
Merge branch 'master' of https://github.com/pandas-dev/pandas into us…
lithomas1 6d49eaf
Fixes
lithomas1 680ffb1
Address code review
lithomas1 1e6da47
Merge branch 'master' into use-nullable-csv
lithomas1 bba1ba9
Merge branch 'master' into use-nullable-csv
lithomas1 d075bed
Finish updating code to master
lithomas1 dc03d0f
Preliminary StringArray support
lithomas1 99afeb4
Fix tests
lithomas1 3e1784d
API: allow nan-likes in StringArray constructor
lithomas1 96ff1da
Revert weird changes & Fix stuff
lithomas1 418e1d2
Remove failing test
lithomas1 25a6c4d
Changes from code review
lithomas1 47d68f7
Merge branch 'master' of https://github.com/pandas-dev/pandas into st…
lithomas1 8257dbd
typo
lithomas1 922436a
Update lib.pyi
lithomas1 2f28086
Update lib.pyx
lithomas1 3ee2198
Update lib.pyx
lithomas1 9426a52
Merge branch 'master' of https://github.com/pandas-dev/pandas into st…
lithomas1 3ee55f2
Updates
lithomas1 fe4981a
Update lib.pyx
lithomas1 a66948a
Update lib.pyx
lithomas1 e852719
Update lib.pyx
lithomas1 91b73bb
disallow invalid nans in stringarray constructor
lithomas1 42ec3e4
Merge branch 'master' into stringarray-nan
lithomas1 41f49d2
add to _from_sequence and fixes
lithomas1 156d29f
Merge branch 'master' into use-nullable-csv
lithomas1 033580f
Update to make work
lithomas1 f437d77
Merge branch 'stringarray-nan' into use-nullable-csv
lithomas1 e4ed02e
Merge branch 'master' into use-nullable-csv
lithomas1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be done at a higher level (i.e. not in the cython code)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would probably require a substantial refactoring of the Python Parser code, which calls this directly.
FWIW, maybe_convert_objects also has a convert_to_nullable_integer param.