Skip to content

TST/BUG: fix 2to3 import rewrite of import pickle #4063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2013
Merged

TST/BUG: fix 2to3 import rewrite of import pickle #4063

merged 2 commits into from
Jun 28, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 27, 2013

In pandas.io.pickle the following statement will not allow python to import
anything due to the following rewrite by 2to3

import pickle -> from . import pickle

This makes the import try to import itself ad infinitum and thus fails.

closes #4062

@ghost ghost assigned cpcloud Jun 27, 2013
@cpcloud
Copy link
Member Author

cpcloud commented Jun 28, 2013

@jreback even though i said 0.13 for this one i'd like to get this in for 0.12 would be nice to be able to run tox on py3.x...

@jreback
Copy link
Contributor

jreback commented Jun 28, 2013

ok by me

@cpcloud
Copy link
Member Author

cpcloud commented Jun 28, 2013

btw i tried w/ numpy 1.5.1 and works fine

cpcloud added 2 commits June 28, 2013 14:47
In pandas.io.pickle the following statement will not allow python to import
anything due to the following rewrite by 2to3

import pickle -> from . import pickle

This make the import try to import itself ad infinitum and thus fails.
cpcloud added a commit that referenced this pull request Jun 28, 2013
TST/BUG: fix 2to3 import rewrite of import pickle
@cpcloud cpcloud merged commit f418a0e into pandas-dev:master Jun 28, 2013
@cpcloud cpcloud deleted the tox-pkl-import-fix branch June 28, 2013 19:47
@ghost
Copy link

ghost commented Jun 29, 2013

I think it's time to ditch tox_prll.sh and move to detox,
tox_prll was a hack from a time when detox was having growing pains.

@cpcloud
Copy link
Member Author

cpcloud commented Jun 29, 2013

is this a dropin replacement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox invocation is broken for python >= 3.2
2 participants