REF: SingleBlockManager dont subclass BlockManager #40625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Internals
jreback
requested changes
Apr 8, 2021
pandas/core/internals/managers.py
Outdated
|
|
||
|
|
||
| class BlockManager(DataManager): | ||
| class _BlockManager(DataManager): |
There was a problem hiding this comment.
can you indicate that this is an abstract class (alt put ABC in the name)
pandas/core/internals/managers.py
Outdated
| @@ -1474,21 +1387,123 @@ def take(self: T, indexer, axis: int = 1, verify: bool = True) -> T: | |||
| consolidate=False, | |||
| ) | |||
|
|
|||
| def _equal_values(self: T, other: T) -> bool: | |||
|
|
|||
| class BlockManager(_BlockManager): | |||
There was a problem hiding this comment.
why don't we actually name it Block2DManager then
There was a problem hiding this comment.
bc (to my chagrin) downstream packages access it
| # Populate known_consolidate, blknos, and blklocs lazily | ||
| self._known_consolidated = False | ||
| # error: Incompatible types in assignment (expression has type "None", | ||
| # variable has type "ndarray") |
There was a problem hiding this comment.
the attributes or the "type ignore"s?
There was a problem hiding this comment.
the type ignores, but certainly can be in a followup
| self._blklocs = None # type: ignore[assignment] | ||
|
|
||
| @classmethod | ||
| def _simple_new(cls, blocks: tuple[Block, ...], axes: list[Index]): |
There was a problem hiding this comment.
shouldn't you have an abc for this?
There was a problem hiding this comment.
nothing in the base class uses _simple_new, so no
There was a problem hiding this comment.
i guess that is the question, why is that?
jreback
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, most of BlockManager becomes _BlockManager which is subclassed by SingleBlockManager and BlockManager, the latter holding only the 2d-specific BM methods.
Motivation: putting BlockManager constructor in cython gives a much bigger gain if we can define
__cinit__, and we can't do that with the two subclasses having mismatched__init__signatures.