REGR: replace with multivalued regex raising #40604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
changed the title
mzeitlin11
added
Internals
pandas/core/internals/blocks.py
Outdated
| # is not indexable | ||
| m = masks[i][ | ||
| mask_pos : mask_pos + blk.shape[0] | ||
| ] # type: ignore[index] |
There was a problem hiding this comment.
i think if you define mib = masks[i] or something that might make this type:ignore unnecessary
pandas/core/internals/blocks.py
Outdated
| if blk.ndim == 1: | ||
| m = masks[i] | ||
| else: | ||
| # GH-39338: _replace_coerce can split a block, so we |
There was a problem hiding this comment.
if it gets split, will it be all-single-column?
There was a problem hiding this comment.
good question will look into that, would help simplify logic
There was a problem hiding this comment.
adjusted to account for this - split is happening in split_and_operate, which looks to always give single column result
jreback
reviewed
Mar 25, 2021
|
|
||
| # GH-39338: _replace_coerce can split a block into | ||
| # single-column blocks, so track the index so we know | ||
| # where to index into the mask |
There was a problem hiding this comment.
may be hard to backport as this code has changed a lot (though possible this particular section has not).
|
thanks @mzeitlin11 |
|
@meeseeksdev backport 1.2.x |
This comment has been minimized.
This comment has been minimized.
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Mar 26, 2021
jreback
pushed a commit
that referenced
this pull request
Mar 26, 2021
) Co-authored-by: Matthew Zeitlin <[email protected]>
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue comes from the first pair in the
regexarg hitting the simple replace path, which causes theObjectBlockto be split. From here, the mask indexing will be wrong, but that will not cause an error unless a later pair hits_replace_regex, which actually uses the mask.