Skip to content

REF: deduplicate group cummin/max #40599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

mzeitlin11
Copy link
Member

After #40584, may as well do this one too.

@mzeitlin11 mzeitlin11 added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Groupby Refactor Internal refactoring of code labels Mar 23, 2021
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @jreback

@jreback jreback added this to the 1.3 milestone Mar 24, 2021
@jreback
Copy link
Contributor

jreback commented Mar 24, 2021

any perf diffs?

OT: we ought to consider just computing both at the same time (but this would require more processing because then we have to look for min/max and then dispatch, so prob not worth it)

@mzeitlin11
Copy link
Member Author

any perf diffs?

OT: we ought to consider just computing both at the same time (but this would require more processing because then we have to look for min/max and then dispatch, so prob not worth it)

ASV's were unaffected. What do you mean by computing both at the same time? As in an enhancement to provide functionality for computing both min/max simultaneously?

@jreback
Copy link
Contributor

jreback commented Mar 24, 2021

What do you mean by computing both at the same time? As in an enhancement to provide functionality for computing both min/max simultaneously?

yes, its more efficient to do this if you know that you want both min and max.

@jreback jreback merged commit 176042b into pandas-dev:master Mar 24, 2021
@mzeitlin11 mzeitlin11 deleted the ref/deduplicate_grp_cummin_max branch March 25, 2021 00:04
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Groupby Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants