ENH: add decimal and thousands args to Styler.format()
#40596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ousands # Conflicts: # pandas/io/formats/style.py # pandas/tests/io/formats/style/test_style.py
jreback
requested changes
Mar 23, 2021
pandas/io/formats/style.py
Outdated
| is a (float, complex). | ||
| """ | ||
|
|
||
| def wrapper(x): |
There was a problem hiding this comment.
can we share code with FloatArrayFormatter in pandas/io/format.py ?
may need to refactor to do that.
There was a problem hiding this comment.
taking a quick look:
- there doesn't seem to be an inherent option for
thousands, justdecimalreplacement in that code. - the FloatArrayFormatter is vectorised but
Stylerdoesdisplay_funcselement-wise (which it can't avoid for processing individual cell styles). I guess this makes it very difficult to refactor across module (unless the fomat_class was called element-wise) - other parameters such as
escapeandsubsetwould have to be wrapped around the format.py code, so it might end up equally complicated anyway?
will have a think over next day.
There was a problem hiding this comment.
@jreback I think the refactor is too complicated at this stage since:
- FloatArrayFormatter doesnt have the
thousandsargument which is main part of this PR. - the above problem about column vectorisation versus element-wise (and the
stylersubsetargument) - the other arguments finding it difficult to exactly replicate existing behaviour.
…ousands # Conflicts: # pandas/tests/io/formats/style/test_style.py
…ousands # Conflicts: # pandas/io/formats/style.py
jreback
approved these changes
Apr 20, 2021
|
thanks @attack68 |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
Apr 21, 2021
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR for Europeans: