Skip to content

TYP: testing.pyi #40594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

TYP: testing.pyi #40594

merged 1 commit into from
Mar 29, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jbrockmendel jbrockmendel added the Typing type annotations, mypy/pyright type checking label Mar 24, 2021
@jbrockmendel
Copy link
Member Author

gentle ping @WillAyd, annotations PRs are piling up and becoming blockers (albeit mostly for further annotations, so no real hurry)

WillAyd
WillAyd reviewed Mar 27, 2021
View reviewed changes
pandas/_libs/testing.pyi

def assert_almost_equal(a, b,
rtol: float = ..., atol: float = ...,
check_dtype: bool = ...,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think check_dtype should just be Union[bool, str] right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the .pyx file its typed as bint, which i think is better anyway; better to make the casting explicit

@jreback jreback added this to the 1.3 milestone Mar 29, 2021
@jreback jreback merged commit ff2884a into pandas-dev:master Mar 29, 2021
@jreback
Copy link
Contributor

jreback commented Mar 29, 2021

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the typ-testing branch March 29, 2021 15:01
@jbrockmendel
Copy link
Member Author

booyah! more of these .pyi files are waiting in the wings once the current crop of TYP PRs go through

vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
@jbrockmendel @vladu
TYP: testing.pyi (pandas-dev#40594)
aceb2e4
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
TYP: testing.pyi (pandas-dev#40594)
5390351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd left review comments

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @WillAyd