Skip to content

TST Add test for loc on sparse dataframes #40593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 2, 2021
Merged

TST Add test for loc on sparse dataframes #40593

merged 5 commits into from
Apr 2, 2021

Conversation

EricLeer
Copy link
Contributor

@EricLeer EricLeer commented Mar 23, 2021 •
edited
Loading

Adds a test for loc on sparse dataframes.

@EricLeer
Copy link
Contributor Author

The test pandas/tests/io/xml/test_xml.py::test_parser_consistency_url seems to be failing, but I am not seeing how I am touching this code by just adding another test. Does anyone know how I would be able to fix this?

@jbrockmendel
Copy link
Member

The test pandas/tests/io/xml/test_xml.py::test_parser_consistency_url seems to be failing, but I am not seeing how I am touching this code by just adding another test. Does anyone know how I would be able to fix this?

This is unrelated and OK to ignore here. Just restarted that build.

@jreback jreback added Sparse Sparse Data Type Testing pandas testing functions or related to the test suite Indexing Related to indexing on series/frames, not to indexes themselves labels Mar 29, 2021
@jreback jreback added this to the 1.3 milestone Mar 30, 2021
@jreback
Copy link
Contributor

jreback commented Mar 30, 2021

@EricLeer the pre-commit is failing if you can have a look

@jreback jreback merged commit e354536 into pandas-dev:master Apr 2, 2021
@jreback
Copy link
Contributor

jreback commented Apr 2, 2021

thanks @EricLeer

vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
@EricLeer @vladu
TST Add test for loc on sparse dataframes (pandas-dev#40593)
a1589f9
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@EricLeer @JulianWgs
TST Add test for loc on sparse dataframes (pandas-dev#40593)
104672f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Sparse Sparse Data Type Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: multiple application of .loc on sparse DataFrame results in NaN and filling the DataFrame
3 participants
@EricLeer @jbrockmendel @jreback