TST: test_highlight.py convert to functional tests not class
#40551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attack68
added
Clean
Styler
jreback
requested changes
Mar 22, 2021
| def test_highlight_null_subset(s): | ||
| # GH 31345 | ||
| result = ( | ||
| s.highlight_null(null_color="red", subset=["A"]) |
There was a problem hiding this comment.
nit: can you line these up on the periods
There was a problem hiding this comment.
black does the aligning here, not me.
| result = getattr(df.style, f)(axis=1, color="red")._compute().ctx | ||
| assert result == expected | ||
| @pytest.fixture | ||
| def s(df): |
There was a problem hiding this comment.
can you call this maybe styler, s is too short
jreback
approved these changes
Mar 23, 2021
|
thanks @attack68 |
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest.fixtureinstead of Class setup method