Skip to content

TYP: internals.pyi #40549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 29, 2021
Merged

TYP: internals.pyi #40549

merged 8 commits into from
Mar 29, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jbrockmendel jbrockmendel added the Typing type annotations, mypy/pyright type checking label Mar 21, 2021
@jreback
Copy link
Contributor

jreback commented Mar 29, 2021

can you rebase

@jreback jreback added this to the 1.3 milestone Mar 29, 2021
@jbrockmendel
Copy link
Member Author

rebased + greenish

@jreback jreback merged commit d7b04d1 into pandas-dev:master Mar 29, 2021
@jreback
Copy link
Contributor

jreback commented Mar 29, 2021

cool. any ideas about the failures on master?

@jreback
Copy link
Contributor

jreback commented Mar 29, 2021

e.g. https://github.com/pandas-dev/pandas/runs/2220118625

@jbrockmendel
Copy link
Member Author

cool. any ideas about the failures on master?

looking into it now

BTW the other open TYP PRs all play together nicely

@jbrockmendel jbrockmendel deleted the typ-libinternals branch March 29, 2021 18:32
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
@jbrockmendel @vladu
TYP: internals.pyi (pandas-dev#40549)
e1ec2fd
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
TYP: internals.pyi (pandas-dev#40549)
e929f6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback