Revert "PERF: increase the minimum number of elements to use numexpr for ops from 1e4 to 1e6" #40541
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this fixes all the builds except docbuild, which should be fixed by #40542 |
|
great merge when ready (and maybe open an issue about the perf change) |
|
This fixes the memory issue I noted on gitter:
|
|
Thanks @jbrockmendel |
Now that you mention it... about 1.3 GB at the end of collection, 6.04 by the time it hits 1%! 2GB matches my recollection of what ive seen recently pre-yesterday |
4 tasks
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
…for ops from 1e4 to 1e6 (pandas-dev#40502)" (pandas-dev#40541)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40502
Troubleshooting the CI