Skip to content

TYP: first_valid_index & last_valid_index #40535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Mar 20, 2021

Typing of first_valid_index & last_valid_index + make the how param in internal functions a named parameter for better readability.

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Mar 22, 2021
@jreback jreback added this to the 1.3 milestone Mar 22, 2021
@jreback jreback merged commit b118e5b into pandas-dev:master Mar 23, 2021
@jreback
Copy link
Contributor

jreback commented Mar 23, 2021

thanks @topper-123

@topper-123 topper-123 deleted the cln_find_valid_index branch March 23, 2021 17:08
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants