STYLE loosen inconsistent namespace check #40532
Conversation
MarcoGorelli
force-pushed
the
loosen-inconsistent-namespace-check
branch
from
c211695 to
a5e0d1f
Compare
There was a problem hiding this comment.
Nice @MarcoGorelli. Was this check still running only for tests? If so maybe it could be extended to ordinary source files too (although it seems that tests are where most of the violations tend to be)?
| self.pandas_namespace: MutableMapping[Offset, str] = {} | ||
| self.no_namespace: Set[str] = set() | ||
| self.pandas_namespace: MutableMapping[OffsetWithNamespace, str] = {} | ||
| self.imported_from_pandas: Set[str] = set() |
There was a problem hiding this comment.
Outside scope of the PR of course, but curious how hard it would be to generalize this to any namespace? Then you could see it being a helpful linting check even outside of pandas.
There was a problem hiding this comment.
That's a great idea, thanks! Added to my backlog
…nt-namespace-check
|
can you merge master; i think the docbuild should be fixed (not sure about the other one) |
|
@MarcoGorelli can you merge master and ping on greenish |
…nt-namespace-check
…nt-namespace-check
|
@MarcoGorelli if you an merge master once more |
…nt-namespace-check
|
@jreback sure, done |
|
thanks @MarcoGorelli |
For context, see #40468, where the error which was fixed was arguably a false-positive.
I've loosened the check so that now it only errors / replaces if:
e.g. from pandas.io.formats import infopd.orpandas.(e.g.pd.infoorpandas.info)Before, it just checked whether an object appeared both with and without the
pd.prefix, which was too tight a check - sorry about that 😳I've also added line number and column offset of the inconsistency for ease of checking/fixing