CLN/TYP: remove unused arguments in merge #40513
Conversation
pandas/core/reshape/merge.py
Outdated
| how: str = "left", | ||
| ): | ||
| ) -> np.ndarray: |
There was a problem hiding this comment.
The docstring for Index.take says that a np.ndarray is returned, but it appears that is not the case.
>>> idx
RangeIndex(start=0, stop=3, step=1)
>>>
>>> idx.take([1])
Int64Index([1], dtype='int64')
>>>
There was a problem hiding this comment.
Thanks for noticing this, opened #40521 to address
pandas/core/reshape/merge.py
Outdated
| join_index: MultiIndex, | ||
| lindexer: np.ndarray, | ||
| rindexer: np.ndarray, | ||
| ) -> Tuple[List[Index], np.ndarray, List[str]]: |
There was a problem hiding this comment.
Can you update the docstring to match for the return type of 'names of combined multiindexes'
There was a problem hiding this comment.
Updated docstring. Plan to take a much deeper dive into this code in followups, will try to clean up more inconsistencies once I have a better handle on what's going on here.
pandas/core/reshape/merge.py
Outdated
| @@ -1583,7 +1578,6 @@ def __init__( | |||
| right_index: bool = False, | |||
| axis: int = 1, | |||
| suffixes: Suffixes = ("_x", "_y"), | |||
| copy: bool = True, | |||
There was a problem hiding this comment.
I think this should be retained since in the base class _MergeOperation.__init__.
There was a problem hiding this comment.
Reverted these changes
|
thanks @mzeitlin11 |
No description provided.