TYP: index.pyi #40486
Merged
TYP: index.pyi #40486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Mar 17, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
pandas/core/indexes/multi.py
Outdated
| @@ -1111,8 +1112,8 @@ def _engine(self): | |||
| # Check the total number of bits needed for our representation: | |||
| if lev_bits[0] > 64: | |||
| # The levels would overflow a 64 bit uint - use Python integers: | |||
| return MultiIndexPyIntEngine(self.levels, self.codes, offsets) | |||
| return MultiIndexUIntEngine(self.levels, self.codes, offsets) | |||
| return MultiIndexPyIntEngine(list(self.levels), self.codes, offsets) | |||
There was a problem hiding this comment.
I don't think should need to change this. should probably be using sequence in BaseMultiIndexCodesEngine.__init__
from https://github.com/python/typeshed/blob/master/CONTRIBUTING.md#conventions
avoid invariant collection types (list, dict) in argument positions, in favor of covariant types like Mapping or Sequence;
|
Updated+green |
simonjayhawkins
approved these changes
Mar 19, 2021
jreback
requested changes
Mar 30, 2021
|
rebased + greenish |
jreback
approved these changes
Mar 30, 2021
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.