TYP: get_reverse_indexer, get_group_index_sorter #40476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
the
Algos
|
any perf changes? |
might be some small gain on 32 bit, nothing on 64. |
pandas/core/indexes/base.py
Outdated
| @@ -4197,17 +4206,19 @@ def _get_leaf_sorter(labels): | |||
| mask = new_lev_codes != -1 | |||
| if not mask.all(): | |||
| new_codes = [lab[mask] for lab in new_codes] | |||
| left_indexer = left_indexer[mask] | |||
| # error: Value of type "Optional[ndarray]" is not indexable | |||
| left_indexer = left_indexer[mask] # type: ignore[index] | |||
There was a problem hiding this comment.
np.arange resolves to Any. https://github.com/numpy/numpy/blob/main/numpy/__init__.pyi
as a result left_indexer is not narrowed with left_indexer = np.arange(len(left), dtype=np.intp) (L4215 after merge master)
so I think in this case better to cast than add an ignore. (We have warn_redundant_casts = True in setup.cfg) so should be aware when the cast is no longer required)
| ) | ||
|
|
||
| # missing values are placed first; drop them! | ||
| left_indexer = left_indexer[counts[0] :] | ||
| # error: Value of type "Optional[ndarray]" is not indexable | ||
| left_indexer = left_indexer[counts[0] :] # type: ignore[index] |
There was a problem hiding this comment.
you could maybe leave this one as a "fix later" ignore instead of a cast as we can fix ourselves by typing libalgos.groupsort_indexer (i.e. adding algos.pyi)
simonjayhawkins
approved these changes
Mar 19, 2021
|
yeah will look a bit later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nailing down all the "np.intp"s bit by little bit.
AFAICT we're not going to be able to annotate ndarrays with ndim/dtype any time soon. Might be worth looking into https://pypi.org/project/nptyping/