Skip to content

TST: csv parser segfaulting on malformed input. #40458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2021
Merged

TST: csv parser segfaulting on malformed input. #40458

merged 4 commits into from
Mar 16, 2021

Conversation

ahawryluk
Copy link
Contributor

@ahawryluk ahawryluk commented Mar 16, 2021 •
edited by jreback
Loading

xref #14782

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

jreback
jreback approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. cc @gfyoung

@jreback jreback added IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite labels Mar 16, 2021
@jreback jreback added this to the 1.3 milestone Mar 16, 2021
jreback
jreback requested changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, ping on green.

@jreback jreback changed the title Old segfault TST: csv parser segfaulting on malformed input. Mar 16, 2021
@jreback
Copy link
Contributor

jreback commented Mar 16, 2021

cool, failures addressed elsewhere, merge on greenish

@jreback jreback merged commit c13027c into pandas-dev:master Mar 16, 2021
@jreback
Copy link
Contributor

jreback commented Mar 16, 2021

thanks @ahawryluk

@ahawryluk ahawryluk deleted the old_segfault branch March 16, 2021 21:45
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@ahawryluk @JulianWgs
TST: csv parser segfaulting on malformed input. (pandas-dev#40458)
0099438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsaxton dsaxton dsaxton left review comments

@jreback jreback jreback approved these changes

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@ahawryluk @jreback @dsaxton @gfyoung