Skip to content

DEPS: sync fastparquet version #40424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 15, 2021

Conversation

fangchenli
Copy link
Member

follow up #38344

@fangchenli fangchenli added the Dependencies Required and optional dependencies label Mar 14, 2021
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the version in TestParquetFastParquet needs updated too.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -916,7 +916,11 @@ def test_filter_row_groups(self, pa):


class TestParquetFastParquet(Base):
@td.skip_if_no("fastparquet", min_version="0.3.2")
from pandas.compat._optional import VERSIONS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this at all, just remove the min version, no?

@jreback jreback added this to the 1.3 milestone Mar 14, 2021
@jreback jreback added the IO Parquet parquet, feather label Mar 14, 2021
@jreback jreback merged commit 7af47c9 into pandas-dev:master Mar 15, 2021
@fangchenli fangchenli deleted the sync-fastparquet-version branch March 18, 2021 16:40
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies IO Parquet parquet, feather
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants