Docs - Grammar fix #40377 #40381
Merged
Docs - Grammar fix #40377 #40381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Mar 11, 2021
pandas/core/groupby/groupby.py
Outdated
| @@ -328,7 +328,7 @@ class providing the base-class of operations. | |||
| engine : str, default None | |||
| * ``'cython'`` : Runs the function through C-extensions from cython. | |||
| * ``'numba'`` : Runs the function through JIT compiled code from numba. | |||
| * ``None`` : Defaults to ``'cython'`` or globally setting ``compute.use_numba`` | |||
| * ``None`` : Defaults to ``'cython'`` or the globally setting ``compute.use_numba`` | |||
There was a problem hiding this comment.
Suggested change
| * ``None`` : Defaults to ``'cython'`` or the globally setting ``compute.use_numba`` | |
| * ``None`` : Defaults to ``'cython'`` or the global setting ``compute.use_numba`` |
There was a problem hiding this comment.
I've made the two commits with grammar fixes. Is it fixed now ?
|
Sure, thanks @Mayurji ! |
|
Thank you @MarcoGorelli |
sthagen
added a commit
to sthagen/pandas-dev-pandas
that referenced
this pull request
Mar 11, 2021
Docs - Grammar fix pandas-dev#40377 (pandas-dev#40381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue:
DOC: Slightly broken grammar for
groupby.applywith fix #40377Made the grammar change as raised in the issue.