STYLE: Extending codespell to pandas/tests/ part3 38802 #40372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
01-vyom
commented
Mar 11, 2021
•
01-vyom
commented
- closes CI/STYLE extend codespell beyond pandas/core #38802
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
MarcoGorelli
approved these changes
Mar 11, 2021
MarcoGorelli
suggested changes
Mar 11, 2021
pandas/tests/io/xml/test_to_xml.py
Outdated
| @@ -411,12 +411,12 @@ def test_attrs_cols_prefix(datapath, parser): | |||
|
|
|||
| def test_attrs_unknown_column(parser): | |||
| with pytest.raises(KeyError, match=("no valid column")): | |||
| geom_df.to_xml(attr_cols=["shape", "degreees", "sides"], parser=parser) | |||
| geom_df.to_xml(attr_cols=["shape", "degrees", "sides"], parser=parser) | |||
There was a problem hiding this comment.
Looks like this is failing a test, might have to choose a different word
|
Done with all the changes. |
|
Thanks @01-vyom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.