ENH: add rmod methods to frame and series #4035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your sure this is necessary #3590 fixed these mod issues |
|
as it stands mod follows |
|
this pr fixes that |
|
so the broadcasting is wrong? |
| @@ -874,7 +876,8 @@ def __contains__(self, key): | |||
| default_axis=None, fill_zeros=np.inf) | |||
| __rpow__ = _arith_method(lambda x, y: y ** x, '__rpow__', | |||
| default_axis=None) | |||
| __rmod__ = _arith_method(operator.mod, '__rmod__', default_axis=None, fill_zeros=np.nan) | |||
There was a problem hiding this comment.
@jreback this line here was calling mod(x, y) when it should be mod(y, x) that's why it was appearing commutative. rmod == mod here when it shouldn't
There was a problem hiding this comment.
incidentally this was caught by my eval test suite
There was a problem hiding this comment.
oh ok that's fine then
as long as exiting and new tests pass
ghost
assigned
|
passes....i'll wait a bit to merge to make sure i didn't forget anything |
|
I tried your fix, didn't realize this was an issue...its essentially not broadcasting..so good to go |
cpcloud
added a commit
that referenced
this pull request
Jun 26, 2013
ENH: add rmod methods to frame and series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.