[ArrayManager] TST: enable apply tests #40345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Internals
|
@jreback @jbrockmendel any comments here? (trying to get all testing PRs merged to reduce the custom selection) |
| tm.assert_frame_equal(df, result) | ||
| if not using_array_manager: | ||
| # INFO(ArrayManager) With BlockManager, the row is a view and mutated in place, | ||
| # with ArrayManager the row is not a view, and thus not mutated in place |
There was a problem hiding this comment.
is there anything we should be asserting in the AM case?
There was a problem hiding this comment.
Added the equivalent assert (but so asserting it didn't change) for AM
|
one question, otherwise LGTM. azure failure looks unrelated. |
|
Failure is an unrelated docstring validation issue that also happens on other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #39146