TYP: Add typing for remaining IO XML methods with conditional for lxml #40340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ParfaitG
commented
Mar 10, 2021
ParfaitG
commented
- references Pandas IO XML Issue Tracker #40131
- tests passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry (not necessary)
jreback
requested changes
Mar 10, 2021
pandas/io/xml.py
Outdated
| @@ -553,31 +535,62 @@ def _validate_names(self) -> None: | |||
| f"{type(self.names).__name__} is not a valid type for names" | |||
| ) | |||
|
|
|||
| def _parse_doc(self, raw_doc): | |||
| if lxml is not None: | |||
There was a problem hiding this comment.
hmm i find this odd that this is not in a function
There was a problem hiding this comment.
I modify this entirely which did not pass ci/code_checks
jreback
added
Typing
jreback
requested changes
Mar 16, 2021
pandas/tests/io/xml/test_xml.py
Outdated
| @@ -253,6 +254,10 @@ def test_parser_consistency_file(datapath): | |||
| @tm.network | |||
| @pytest.mark.slow | |||
| @td.skip_if_no("lxml") | |||
| @pytest.mark.skipif( | |||
| sys.version_info < (3, 8), | |||
There was a problem hiding this comment.
can you use the PY38 from compat
jreback
approved these changes
Mar 16, 2021
|
this is fine, ping when CI finishes and greenish (failure is being fixed elsewhere) |
|
thanks @ParfaitG |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.