[ArrayManager] TST: run (+fix/skip) pandas/tests/series/indexing tests #40326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Indexing
jbrockmendel
reviewed
Mar 9, 2021
jbrockmendel
reviewed
Mar 9, 2021
| raise ValueError( | ||
| "Passed array should be 1-dimensional, got array with " | ||
| f"{arr.ndim} dimensions instead." | ||
| ) |
There was a problem hiding this comment.
can you share any of this with the parent classes' _verify_integrity?
There was a problem hiding this comment.
Not really, I think. The parent version assumes the object is 2D, so won't work for SingleArrayManager.
I assume that the part of _verify_integrity that checks the individual array could be factored out into a shared helper function, but I would rather leave that for a follow-up.
jbrockmendel
reviewed
Mar 9, 2021
jbrockmendel
reviewed
Mar 9, 2021
|
LGTM cc @jreback |
|
thanks @jorisvandenbossche |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #39146
Getting the tests passing for the indexing tests, her for
pandas/tests/series/indexing(pandas/tests/indexingis done in #40325 andpandas/tests/frame/indexingis done in #40323)