BUG: Fix sort_values for empty by argument #40324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dsaxton
commented
Mar 9, 2021
dsaxton
commented
- closes BUG: df.sort_values(by=[]) fails with IndexError #40258
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
dsaxton
added
Bug
Algos
jreback
requested changes
Mar 9, 2021
pandas/core/frame.py
Outdated
| @@ -5833,6 +5833,8 @@ def sort_values( # type: ignore[override] | |||
| indexer = nargsort( | |||
| k, kind=kind, ascending=ascending, na_position=na_position, key=key | |||
| ) | |||
| else: | |||
| return self | |||
| @@ -79,6 +79,10 @@ def test_sort_values(self): | |||
| with pytest.raises(ValueError, match=msg): | |||
| frame.sort_values(by=["A", "B"], axis=0, ascending=[True] * 5) | |||
|
|
|||
| # https://github.com/pandas-dev/pandas/issues/40258 | |||
There was a problem hiding this comment.
can you add a separate test. also assert that it is not the same frame.
There was a problem hiding this comment.
can you make a completely separate test
There was a problem hiding this comment.
we dont' normally want to mix error checking with other things
jreback
reviewed
Mar 9, 2021
doc/source/whatsnew/v1.2.4.rst
Outdated
| @@ -25,7 +25,7 @@ Fixed regressions | |||
| Bug fixes | |||
| ~~~~~~~~~ | |||
|
|
|||
| - | |||
| - Fixed bug in :meth:`DataFrame.sort_values` raising an :class:`IndexError` for empty ``by`` (:issue:`40258`) | |||
There was a problem hiding this comment.
move to 1.3, this is an expansion not a regression.
| @@ -79,6 +79,10 @@ def test_sort_values(self): | |||
| with pytest.raises(ValueError, match=msg): | |||
| frame.sort_values(by=["A", "B"], axis=0, ascending=[True] * 5) | |||
|
|
|||
| # https://github.com/pandas-dev/pandas/issues/40258 | |||
There was a problem hiding this comment.
can you make a completely separate test
| @@ -79,6 +79,10 @@ def test_sort_values(self): | |||
| with pytest.raises(ValueError, match=msg): | |||
| frame.sort_values(by=["A", "B"], axis=0, ascending=[True] * 5) | |||
|
|
|||
| # https://github.com/pandas-dev/pandas/issues/40258 | |||
There was a problem hiding this comment.
we dont' normally want to mix error checking with other things
jreback
approved these changes
Mar 9, 2021
|
thanks @dsaxton |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.