STYLE use pd_array in core

[MarcoGorelli]

As requested by @jbrockmendel here

[jbrockmendel]

@MarcoGorelli i think an easier solution is

construction.py:

def pd_array(...):

__init__.py:

from pandas.core.construction import pd_array as array

[jorisvandenbossche]

Sorry to have a contradictory opinion .. but I am personally think that using the import alias where it's used is nicer. I would prefer to keep the actual name of the function (array) the same as the name how it is exposed publicly, since you still see this name (eg in the repr of the function object), and it's only distracting if that's different IMO.

[jorisvandenbossche]

For me this is fine (but it's @jbrockmendel that suggested otherwise)

The linting error seems relevant.

[jbrockmendel]

joris makes a reasonable point about repr(pd_array). im fine with the approach in this PR

[MarcoGorelli]

The linting error seems relevant.

Indeed - fixed, thanks!

[jorisvandenbossche]

@MarcoGorelli can you do another (final) merge of master to be sure there are no new failures?

[jreback]

lgtm. @MarcoGorelli can you merge master and ping on greenish

[jreback]

@MarcoGorelli if you can merge master once more

[jreback]

thanks @MarcoGorelli