Skip to content

Add layout keyword to dataframe.hist() #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2013

Conversation

danbirken
Copy link
Contributor

closes #4050. The current version defaults to a very sane default, but sometimes for presentation I prefer them all to be all in a row, or all in a column, or some non-balanced mix of the two. This keyword gives the flexibility for all of those options.

@jreback
Copy link
Contributor

jreback commented Jun 26, 2013

is this a 'standard' option name? it seems intuitive, but does mp use this in a similar context (or some other keyword)? just asking, seems logical

@jreback
Copy link
Contributor

jreback commented Jun 26, 2013

fyi..in future, pls create an issue, then reference it in the PR, we can label issues so categorizing is easier..thanks!

@danbirken
Copy link
Contributor Author

Sorry about that, was unaware about the issue preference. Made issue #4050, added issue to release notes and original commit message.

As for the name, I just copied the name/interface of "layout" from plotting.grouped_hist(...). I don't know too much about the collision with matplotlib, other than when matplotlib is talking about layouts they are referring to the same type of thing, and it doesn't appear to me that matplotlib actively uses this keyword. However, I am perfectly happy to change it, I have no strong connections to this name.

I think perhaps the best alternative would be to break this into two keywords: rows/cols?

@jreback
Copy link
Contributor

jreback commented Jun 26, 2013

this looks good
can you hook up Travis?
then recommit?

git commit --amend -C HEAD

@danbirken
Copy link
Contributor Author

Alright, Travis is hooked up. One particular unrelated test is a bit flakey, but otherwise the tests are all passing: https://travis-ci.org/danbirken/pandas

@cpcloud
Copy link
Member

cpcloud commented Jun 28, 2013

@danbirken flaky tests should be resolved...can u rebase and push again? thx

@danbirken
Copy link
Contributor Author

There we go. Still had a transient failure, but after resetting that test, we are fully green.

jreback added a commit that referenced this pull request Jun 29, 2013
@jreback jreback merged commit 07403ca into pandas-dev:master Jun 29, 2013
@jreback
Copy link
Contributor

jreback commented Jun 29, 2013

@danbirken thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The layout of dataframe histograms should be customizable
3 participants