[ArrayManager] Add Series._as_manager (consolidate with DataFrame) #40304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
the
Internals
jreback
requested changes
Mar 8, 2021
| new_mgr = arrays_to_mgr( | ||
| mgr.arrays, mgr.axes[0], mgr.axes[1], mgr.axes[0], typ="block" | ||
| ) | ||
| if mgr.ndim == 2: |
There was a problem hiding this comment.
I personally wouldn't find that an improvement in readability. Now it's very clearly separated into two cases (manager already has the same type -> use as is, or else the manager needs to be converted)
There was a problem hiding this comment.
using nested elif/if is an anti-pattern
There was a problem hiding this comment.
It's only an anti-pattern if it's deeply nested and hampering readability. In this case, it makes the code easier to understand IMO.
| elif typ == "array": | ||
| if isinstance(mgr, ArrayManager): | ||
| new_mgr = mgr | ||
| else: | ||
| arrays = [mgr.iget_values(i).copy() for i in range(len(mgr.axes[0]))] | ||
| new_mgr = ArrayManager(arrays, [mgr.axes[1], mgr.axes[0]]) | ||
| if mgr.ndim == 2: |
jreback
approved these changes
Mar 16, 2021
|
Thanks |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
_as_managerhelper togeneric.py, and ensure it works for Series as well