[ArrayManager] TST: enable IO tests #40298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Testing
|
Some failing SQL tests use |
|
looks like array manager tests are reporting failures? |
|
Yes, there are still a few errors I need to skip (parquet test outside of test_parquet.py). But the strange thing is that the github action kept running, although the output shows it finished (6 failed, 7616 passed, 2180 skipped, 280 deselected, 23 xfailed, 3 xpassed in 192.71s (0:03:12)). But after the IO tests, it never continued with the next tests .. |
|
Now it's passing |
|
Going to merge, since this is just adding some skips for ArrayManager |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #39146
This basically just adds IO testing to the set of tests we run for ArrayManager. I already added skips for JSON in the past (and now also for PyTables IO and pickle), so those are still skipped now as well.