ENH: consistent Styler.highlight_X arg signature with props
#40242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jreback
requested changes
Mar 5, 2021
pandas/io/formats/style.py
Outdated
| -------- | ||
| Styler.highlight_max: Highlight the maximum with a style. | ||
| Styler.highlight_min: Highlight the minimum with a style. | ||
| Styler.highlight_quantile: Highlight values defined by a quantile with a style. |
There was a problem hiding this comment.
need to take these new highlites out
pandas/io/formats/style.py
Outdated
|
|
||
| Notes | ||
| ----- | ||
| Uses ``pandas.isna()`` to detect the missing values. |
There was a problem hiding this comment.
why is this here? we use isna for detecting missing values by default, so this is not surprising.
pandas/io/formats/style.py
Outdated
| -------- | ||
| Styler.highlight_null: Highlight missing values with a style. | ||
| Styler.highlight_max: Highlight the maximum with a style. | ||
| Styler.highlight_quantile: Highlight values defined by a quantile with a style. |
jreback
approved these changes
Mar 5, 2021
|
lgtm. ping on greenish (or green if you had rebased recently) |
|
@jreback green now |
|
thanks @attack68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits #39821 into separate PRs.
The
See Alsodoc strings here reference methods created in those PRs - if we push this through now I will fix it later if those methods don't get approved before 1.3.0.The tests that were edited contained redundant code and were not testing.