Skip to content

CI autofix_prs: false for pre-commit.ci #40232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2021
Merged

CI autofix_prs: false for pre-commit.ci #40232

merged 1 commit into from
Apr 13, 2021

Conversation

MarcoGorelli
Copy link
Member

Somehow, this autoupdate job doesn't trigger all the workflows. I don't know why, because the same workflow in PyMC3 works just fine.

From this action's README, all the actions have commit email and commit name set - setting them is all I can think to try at the moment. @afeld any ideas? Maybe there's a different workflow that should be used instead?

@MarcoGorelli MarcoGorelli requested a review from afeld March 4, 2021 20:12
@jreback jreback added the CI Continuous Integration label Mar 5, 2021
@jreback jreback added this to the 1.3 milestone Mar 5, 2021
@afeld
Copy link
Member

afeld commented Mar 19, 2021

Sorry for the slow response. The difference between pandas (e.g. #40439) and pymc3 (e.g. pymc-devs/pymc#4466) is that the former is sending the pull request from @github-actions. More info, with workaround.

@MarcoGorelli
Copy link
Member Author

Thanks @afeld , that's useful! I'll get back to this

@MarcoGorelli MarcoGorelli marked this pull request as draft March 19, 2021 18:42
@MarcoGorelli MarcoGorelli changed the title CI Set autoupdate in githubactions name CI Use personal access token for pre-commit autoupdate job Mar 21, 2021
@MarcoGorelli

This comment has been minimized.

Sign in to view
@MarcoGorelli MarcoGorelli marked this pull request as ready for review March 21, 2021 09:44
@MarcoGorelli MarcoGorelli requested a review from jreback March 21, 2021 12:59
@MarcoGorelli MarcoGorelli marked this pull request as draft April 11, 2021 09:56
@MarcoGorelli MarcoGorelli force-pushed the autoupdate-change-user branch from 538a07f to 2a8c65a Compare April 13, 2021 10:42
@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 13, 2021 10:43
@MarcoGorelli MarcoGorelli changed the title CI Use personal access token for pre-commit autoupdate job CI autofix_prs: false for pre-commit.ci Apr 13, 2021
@MarcoGorelli
Copy link
Member Author

I've repurposed this to set autofix_prs: false in the settings for pre-commit.ci - if we enable it then we can get rid of .github/workflows/comment_bot.yml, .github/workflows/autoupdate-pre-commit-config.yml, and .github/workflows/pre-commit.yml

@jreback
Copy link
Contributor

jreback commented Apr 13, 2021

I've repurposed this to set autofix_prs: false in the settings for pre-commit.ci - if we enable it then we can get rid of .github/workflows/comment_bot.yml, .github/workflows/autoupdate-pre-commit-config.yml, and .github/workflows/pre-commit.yml

sounds good

@jreback jreback merged commit eea8043 into pandas-dev:master Apr 13, 2021
@MarcoGorelli MarcoGorelli deleted the autoupdate-change-user branch April 13, 2021 12:35
@MarcoGorelli
Copy link
Member Author

Awesome - @jreback do you want to re-enable pre-commit-ci then? It should be in settings -> integrations

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@MarcoGorelli @JulianWgs
ci - autofix_prs: false (pandas-dev#40232)
35a0856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afeld afeld Awaiting requested review from afeld

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoGorelli @afeld @jreback