Skip to content

TST: remove some no longer necessary ArrayManager skips for groupby #40216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pandas/tests/frame/methods/test_count.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import numpy as np
import pytest

import pandas.util._test_decorators as td

from pandas import (
DataFrame,
Index,
Expand Down Expand Up @@ -109,7 +107,6 @@ def test_count_index_with_nan(self):
)
tm.assert_frame_equal(res, expected)

@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) groupby
def test_count_level(
self,
multiindex_year_month_day_dataframe_random_data,
Expand Down
2 changes: 0 additions & 2 deletions pandas/tests/frame/methods/test_drop.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import pytest

from pandas.errors import PerformanceWarning
import pandas.util._test_decorators as td

import pandas as pd
from pandas import (
Expand Down Expand Up @@ -161,7 +160,6 @@ def test_drop(self):
assert return_value is None
tm.assert_frame_equal(df, expected)

@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) groupby
def test_drop_multiindex_not_lexsorted(self):
# GH#11640

Expand Down
3 changes: 0 additions & 3 deletions pandas/tests/frame/methods/test_reorder_levels.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import numpy as np
import pytest

import pandas.util._test_decorators as td

from pandas import (
DataFrame,
MultiIndex,
Expand Down Expand Up @@ -52,7 +50,6 @@ def test_reorder_levels(self, frame_or_series):
result = obj.reorder_levels(["L0", "L0", "L0"])
tm.assert_equal(result, expected)

@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) groupby
def test_reorder_levels_swaplevel_equivalence(
self, multiindex_year_month_day_dataframe_random_data
):
Expand Down
4 changes: 0 additions & 4 deletions pandas/tests/frame/methods/test_reset_index.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
import numpy as np
import pytest

import pandas.util._test_decorators as td

from pandas.core.dtypes.common import (
is_float_dtype,
is_integer_dtype,
Expand Down Expand Up @@ -550,7 +548,6 @@ def test_reset_index_delevel_infer_dtype(self):
assert is_integer_dtype(deleveled["prm1"])
assert is_float_dtype(deleveled["prm2"])

@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) groupby
def test_reset_index_with_drop(
self, multiindex_year_month_day_dataframe_random_data
):
Expand Down Expand Up @@ -649,7 +646,6 @@ def test_reset_index_empty_frame_with_datetime64_multiindex():
tm.assert_frame_equal(result, expected)


@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) groupby
def test_reset_index_empty_frame_with_datetime64_multiindex_from_groupby():
# https://github.com/pandas-dev/pandas/issues/35657
df = DataFrame({"c1": [10.0], "c2": ["a"], "c3": pd.to_datetime("2020-01-01")})
Expand Down
3 changes: 0 additions & 3 deletions pandas/tests/frame/methods/test_sort_index.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import numpy as np
import pytest

import pandas.util._test_decorators as td

import pandas as pd
from pandas import (
CategoricalDtype,
Expand Down Expand Up @@ -373,7 +371,6 @@ def test_sort_index_multiindex(self, level):
result = df.sort_index(level=level, sort_remaining=False)
tm.assert_frame_equal(result, expected)

@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) groupby
def test_sort_index_intervalindex(self):
# this is a de-facto sort via unstack
# confirming that we sort in the order of the bins
Expand Down
2 changes: 0 additions & 2 deletions pandas/tests/groupby/aggregate/test_aggregate.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ def test_groupby_aggregation_multi_level_column():
tm.assert_frame_equal(result, expected)


@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) non-cython agg
def test_agg_apply_corner(ts, tsframe):
# nothing to group, all NA
grouped = ts.groupby(ts * np.nan)
Expand Down Expand Up @@ -215,7 +214,6 @@ def test_aggregate_str_func(tsframe, groupbyfunc):
tm.assert_frame_equal(result, expected)


@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) non-cython agg
def test_agg_str_with_kwarg_axis_1_raises(df, reduction_func):
gb = df.groupby(level=0)
if reduction_func in ("idxmax", "idxmin"):
Expand Down
4 changes: 0 additions & 4 deletions pandas/tests/groupby/transform/test_transform.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
import numpy as np
import pytest

import pandas.util._test_decorators as td

from pandas.core.dtypes.common import (
ensure_platform_int,
is_timedelta64_dtype,
Expand Down Expand Up @@ -190,8 +188,6 @@ def test_transform_axis_1(request, transformation_func, using_array_manager):
tm.assert_equal(result, expected)


# TODO(ArrayManager) groupby().transform returns DataFrame backed by BlockManager
@td.skip_array_manager_not_yet_implemented
def test_transform_axis_ts(tsframe):

# make sure that we are setting the axes
Expand Down
3 changes: 0 additions & 3 deletions pandas/tests/reshape/merge/test_join.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import numpy as np
import pytest

import pandas.util._test_decorators as td

import pandas as pd
from pandas import (
Categorical,
Expand Down Expand Up @@ -553,7 +551,6 @@ def test_join_non_unique_period_index(self):
)
tm.assert_frame_equal(result, expected)

@td.skip_array_manager_not_yet_implemented # TODO(ArrayManager) groupby
def test_mixed_type_join_with_suffix(self):
# GH #916
df = DataFrame(np.random.randn(20, 6), columns=["a", "b", "c", "d", "e", "f"])
Expand Down