BUG: constructing DTA/TDA from xarray/dask/pandasarray #40210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Mar 3, 2021
jbrockmendel
commented
- closes sequence_to_dt64ns doesn't handle non-ndarray sequences with a dtype #24539
- closes Accept PandasArray (with correct dtype) in DatetimeArray constructor #24615
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
gfyoung
added
Bug
Constructors
jreback
approved these changes
Mar 16, 2021
|
lgtm, is this user facing at all? or only library facing? e.g. seems now can construct |
this works on master.
AFAICT only library-facing. |
|
looks like a mypy complaint crept in. updated #40361 to fix it |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.