Skip to content

BUG: allow series to use gcf-style figures #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2013
Merged

BUG: allow series to use gcf-style figures #4021

merged 2 commits into from
Jun 28, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 25, 2013

cc @fonnesbeck

here's the original issue: 51cc9d9#commitcomment-3494266

@ghost ghost assigned cpcloud Jun 25, 2013
@cpcloud
Copy link
Member Author

cpcloud commented Jun 25, 2013

@fonnesbeck can u try this out? @jreback any thoughts?

@cpcloud
Copy link
Member Author

cpcloud commented Jun 26, 2013

@jreback couple of things here: possible issue is the new-ish API change that if figure and by are given an error will be raised saying that you cannot pass figure and by since the figure will be discarded with grouped hist plots; i feel like this is something @wesm might give a big 👎 to...personally i would prefer to get an error telling me my passed figure won't be used. OTOH i could certainly make _subplots take a figure argument.

@cpcloud
Copy link
Member Author

cpcloud commented Jun 27, 2013

@jreback can we get this in to 0.12?

@jreback
Copy link
Contributor

jreback commented Jun 27, 2013

is what Series.plot does (take from the current figure)?

@cpcloud
Copy link
Member Author

cpcloud commented Jun 27, 2013

yep

@jreback
Copy link
Contributor

jreback commented Jun 27, 2013

looks reasonable

@cpcloud
Copy link
Member Author

cpcloud commented Jun 27, 2013

actually what i said was slightly wrong: nothing is done with the figure unless the current axis has ticks on the right yaxis.

@wesm
Copy link
Member

wesm commented Jun 27, 2013

this looks fine to me

@cpcloud
Copy link
Member Author

cpcloud commented Jun 28, 2013

will merge after failing test fix

cpcloud added a commit that referenced this pull request Jun 28, 2013
BUG: allow series to use gcf-style figures
@cpcloud cpcloud merged commit f3a301d into pandas-dev:master Jun 28, 2013
@cpcloud cpcloud deleted the hist-figure-arg-fix branch June 28, 2013 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants