CLN: Refactor tests and delete duplicates #40181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Mar 2, 2021
pandas/conftest.py
Outdated
| @@ -1598,6 +1598,14 @@ def indexer_sl(request): | |||
| return request.param | |||
|
|
|||
|
|
|||
| @pytest.fixture(params=[tm.at, tm.loc]) | |||
| def indexer_sa(request): | |||
There was a problem hiding this comment.
maybe indexer_al or indexer_la?
There was a problem hiding this comment.
Ok with me, added the s because of the setitem
There was a problem hiding this comment.
yeah I would ideally make these a bit more descriptive (all of them), at the expense of slightyl increasing length :-> (but let's do this as a followon).
There was a problem hiding this comment.
Will put up something after this is merged
jbrockmendel
reviewed
Mar 4, 2021
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted a few duplicates and parametrized