PERF: don't sort data twice in groupby apply when not using libreduction fast_apply #40176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #40171 (comment) for context, noticed that we were calling
splitter._get_sorted_data()
twice when using the non-fast_apply fallback.Using the benchmark case from
groupby.Apply.time_scalar_function_single/multi_col
(like in #40171 (comment)), but then with bigger data (10 ** 6
instead of10 ** 4
):I get