CLN: remove never-hit branch from maybe_infer_to_datetimelike #40109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Feb 27, 2021
| @@ -1562,7 +1562,7 @@ def infer_datetimelike_array(arr: ndarray[object]) -> str: | |||
| seen_tz_aware = True | |||
|
|
|||
| if seen_tz_naive and seen_tz_aware: | |||
| return 'mixed' | |||
| return "mixed" | |||
There was a problem hiding this comment.
cc @MarcoGorelli would not be averse to a pre-commit to make sure quoting is uniform per file (e.g. either ' or "), ideally we should just be uniform across the entire codebase.
There was a problem hiding this comment.
black ensures we use double in the python code; the cython is a mishmash but mostly double at this point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some annotations and "pragma: no cover" for cases that are also checked by mypy