Skip to content

STYLE exclude io from inconsistent namespace check #40104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

STYLE exclude io from inconsistent namespace check #40104

wants to merge 1 commit into from

Conversation

MarcoGorelli
Copy link
Member

xref #40069 (comment)

  • Ensure all linting tests pass, see here for how to run them

@jreback
Copy link
Contributor

jreback commented Feb 27, 2021

is this still needed? we merged the patch on master.

@jreback jreback added the Code Style Code style, linting, code_checks label Feb 27, 2021
@MarcoGorelli
Copy link
Member Author

My thinking was that this'd prevent unnecessary future error messages from the hook, but maybe the correct thing would be to change such objects so they're imported directly from pandas.io (as was done in the patch) as that's more explicit anyway - closing then

@MarcoGorelli MarcoGorelli deleted the io-namespace branch February 27, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGorelli @jreback