-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPS: replace pyperclip with pyclip #39834 #40101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fangchenli
commented
Feb 27, 2021
•
edited
Loading
edited
- closes DEPS: change clipboard backend to pyclip #39834
wouldn't we need to include this as a dependency? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update the install.rst instructions for this
can you add a note in the whatsnew (put in the deps section, use a ..warning). as this is basically a breaking change.
so we may want to consider leaving the original impl here (though i find that annoying).
thoughts @pandas-dev/pandas-core
Here's my 2 cents, and I will leave it to the more experienced members of the core team to weigh in. The proposal is that we depend on
So unless But others may feel differently, because |
I'll only add that it appears pyperclip requires less on our side, which I love. But I agree with @Dr-Irv assessment. I feel wary adding a 2 month old project, even as an optional dependency. I also wonder how used this feature is (SO gives 161 results for |
I think this is a nearly interactive only function, so I'm not sure it will show up much in github. I have used it a few times in the past month in quick experiments. |
|
thanks @fangchenli let's reconsider this after the project is a bit more mature. |