Skip to content

STYLE: Inconsistent namespace - apply (pandas-dev#39992) #40029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2021
Merged

STYLE: Inconsistent namespace - apply (pandas-dev#39992) #40029

merged 1 commit into from
Feb 24, 2021
+10 −12

Conversation

punitvara
Copy link
Contributor

@punitvara punitvara commented Feb 24, 2021 •
edited
Loading

Fix inconsistent namespace in apply directory.

MarcoGorelli
MarcoGorelli approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @punitvara , pending green this looks good to me

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Feb 24, 2021
@MarcoGorelli MarcoGorelli added this to the 1.3 milestone Feb 24, 2021
MarcoGorelli
MarcoGorelli suggested changes Feb 24, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a whatsnew note, can you revert it please?

It looks like you've done this correctly, but now some of the other hooks are failing (e.g. black, can you fix them up please?

@punitvara
Copy link
Contributor Author

punitvara commented Feb 24, 2021 •
edited
Loading

@MarcoGorelli Sure. I have reverted it back. Thanks for guiding me. Hope this looks fine now.

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Feb 24, 2021 •
edited
Loading

Hope this looks fine now.

You still need to fixup the error from the black formatter

pre-commit run --files pandas/tests/apply/test_frame_apply.py pandas/tests/apply/test_series_apply.py

Or just comment @github-actions pre-commit and that'll trigger a workflow which'll fix it up for you

@punitvara
STYLE: Inconsistent namespace - apply (pandas-dev#39992)
7f70957 
Fix inconsistent namespace in apply directory.
@punitvara
Copy link
Contributor Author

Done.

MarcoGorelli
MarcoGorelli approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's correct, thanks!

@jreback
Copy link
Contributor

jreback commented Feb 24, 2021

@MarcoGorelli go ahead and merge PRs like this that are all green-ish

@MarcoGorelli
Copy link
Member

sure, thanks - flake8 and the rest pass, so this should be good to go

@MarcoGorelli MarcoGorelli merged commit 4502c2e into pandas-dev:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@punitvara @MarcoGorelli @jreback