CI/TST: Supply dtype to coo_matrix until scipy is fixed #40020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Testing
jreback
reviewed
Feb 24, 2021
| sp_array = scipy.sparse.coo_matrix((data, (row, col))) | ||
| # TODO: Remove dtype when scipy is fixed | ||
| # https://github.com/scipy/scipy/issues/13585 | ||
| sp_array = scipy.sparse.coo_matrix((data, (row, col)), dtype="int64") |
|
going to backport as well, ping on green. |
|
Windows 3.7 np1.6 was successful, failures look unrelated. Running again. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jreback - greenish Failing test is |
oh that's prob something we just merged cc @jbrockmendel |
|
thanks @rhshadrach |
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 24, 2021
…l scipy is fixed
will take a look |
jreback
pushed a commit
that referenced
this pull request
Feb 25, 2021
… fixed (#40034) Co-authored-by: Richard Shadrach <[email protected]>
10 tasks
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI for Windows 3.7 np1.6; regression in scipy 1.6.1 (scipy/scipy#13585)
Alternative would be to pin build, wasn't sure which is prefered over the other. Will open tracking issue once the method is decided.