Skip to content

BUG: Cannot sample on DataFrameGroupBy with weights when index is specified #40015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 24, 2021
Merged

BUG: Cannot sample on DataFrameGroupBy with weights when index is specified #40015

merged 4 commits into from
Feb 24, 2021

Conversation

wjsi
Copy link
Contributor

@wjsi wjsi commented Feb 24, 2021 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Feb 24, 2021 •
edited
Loading

Hello @wjsi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-24 16:53:56 UTC

@wjsi wjsi force-pushed the bugfix/groupby_sample_int_idx branch 2 times, most recently from 2f26be7 to 1dbed44 Compare February 24, 2021 12:41
@wjsi wjsi force-pushed the bugfix/groupby_sample_int_idx branch from 1dbed44 to a269b76 Compare February 24, 2021 12:48
rhshadrach
rhshadrach requested changes Feb 24, 2021
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Changes look really good, two minor requests.

@rhshadrach rhshadrach added this to the 1.3 milestone Feb 24, 2021
@rhshadrach
Copy link
Member

Also need a note in the 1.3.0 whatsnew under GroupBy Bug Fixes

@wjsi wjsi requested a review from rhshadrach February 24, 2021 15:37
rhshadrach
rhshadrach approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - cc @jreback

jreback
jreback approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green.

@rhshadrach rhshadrach merged commit 85182df into pandas-dev:master Feb 24, 2021
@rhshadrach
Copy link
Member

Thanks @wjsi!

@wjsi wjsi deleted the bugfix/groupby_sample_int_idx branch February 24, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Bug Groupby
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: Cannot sample on DataFrameGroupBy with weights when index is specified
4 participants
@wjsi @pep8speaks @rhshadrach @jreback