Skip to content

BUG: rolling not calculating window bounds correctly with offset and desc dates #40006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2021
Merged

BUG: rolling not calculating window bounds correctly with offset and desc dates #40006

merged 1 commit into from
Feb 24, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 23, 2021

@phofl phofl added the Window rolling, ewma, expanding label Feb 23, 2021
@jreback jreback added this to the 1.3 milestone Feb 24, 2021
jreback
jreback approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. cc @mroeschke

@mroeschke mroeschke merged commit 84a9a65 into pandas-dev:master Feb 24, 2021
@mroeschke
Copy link
Member

Thanks @phofl. CI failure was unrelated

@phofl phofl deleted the 40002 branch March 4, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Window rolling, ewma, expanding
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: rolling with time window does not always pick edge correctly
3 participants
@phofl @mroeschke @jreback