sort_index not sorting when multi-index made by different categorical types #39986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ftrihardjo
commented
Feb 23, 2021
•
ftrihardjo
commented
- closes sort_index not sorting when multi-index made by different categorical types #24271
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
Hello @ftrihardjo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-13 05:02:37 UTC |
|
Hi @ftrihardjo - could you put "closes #24271" in the pull request description and put a descriptive title (e.g. the name of the issue) please? |
ftrihardjo
changed the title
jreback
added
MultiIndex
Testing
jreback
requested changes
Feb 25, 2021
pandas/tests/groupby/test_groupby.py
Outdated
| @@ -146,6 +146,33 @@ def func(dataf): | |||
| assert isinstance(result, DataFrame) | |||
|
|
|||
|
|
|||
| def test_multi_index_sort(): | |||
There was a problem hiding this comment.
can you rename to
test_sorting_with_different_categoricals
There was a problem hiding this comment.
move to test_categorical.py (same directory)
jreback
approved these changes
Mar 15, 2021
|
thanks @ftrihardjo |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.