DOC : Updated the comparison with spreadsheets with GroupBy #39965

0xpranjal · 2021-02-22T06:19:14Z

part of DOC: add comparison to spreadsheets #38990
tests added / passed
Ensure all linting tests pass, see here for how to run them
whatsnew entry

doc/source/getting_started/comparison/comparison_with_spreadsheets.rst

afeld

FYI that I'm mentoring @Bhard27 through HackIllinois (#39349), so am being more nitpicky than I would for most pull request reviews.

Nice work! I believe the build failure is a flaky test unrelated to this change, so can be ignored.

Unfortunately, Power Query doesn't seem to be compatible with Office 365 or Office for Mac, which are the versions I have, so I can't try it.

We do have a section on Pivot Tables below, which is a different way of grouping by row. Let's:

Create sub-headings under GroupBy for Power Query and Pivot Tables, moving the content for the latter up
Explicitly state that Excel defines "pivot" more broadly than pandas

Thanks!

afeld · 2021-02-25T03:51:44Z

doc/source/getting_started/comparison/comparison_with_spreadsheets.rst

+To aggregate a column, select the column to perform the Aggregate Operation on from the Column drop-down.
+A Row Operation does not require a Column, since data is grouped based on table rows.
+
+.. image:: ../../_static/spreadsheets/group-by.png


Right now, this section duplicates content from the canonical documentation, which doesn't add any value. I suggest we either:

Walk them through an example in Excel that matches the pandas example below, so we are comparing apples to apples

Cut from "Then using the…" through this image

@afeld - are you good here?

Reviewing this again, I see that the requested change was not made. I also agree that having an excel example that matches the pandas example would be desirable.

@Bhard27 Are you able to update the excel image to match the pandas example below?

doc/source/getting_started/comparison/comparison_with_spreadsheets.rst

afeld · 2021-02-25T04:05:53Z

doc/source/getting_started/comparison/comparison_with_spreadsheets.rst

+    # default is axis=0
+    grouped = df.groupby("class")
+    grouped = df.groupby("order", axis="columns")
+    grouped = df.groupby(["class", "order"])


Assigning to a variable doesn't output anything, and even if it did, it would be something not useful like

<pandas.core.groupby.generic.DataFrameGroupBy object at 0x7f8424dc3d90>

Let's do groupby().mean() to show something more interesting.

afeld · 2021-02-25T04:09:34Z

doc/source/getting_started/comparison/comparison_with_spreadsheets.rst

+In Excel, this can be done by using the `Query Editor <https://support.microsoft.com/en-us/office/introduction-to-the-query-editor-power-query-1d6cdb63-bf70-4ae8-a7d5-6ae9547004d9>`_.
+You can group the values in various rows into a single value by grouping the rows according to the values in one or more columns
+Then using the `Query Editor ribbon <https://support.microsoft.com/en-us/office/combine-data-from-multiple-data-sources-power-query-70cfe661-5a2a-4d9d-a4fe-586cc7878c7d>`_, Right-click the column header that you want to group on,
+and click `Group By <https://support.microsoft.com/en-us/office/group-rows-in-a-table-power-query-e1b9e916-6fcc-40bf-a6e8-ef928240adf1>`_.


I could see Excel changing where to find the Query Editor, so let's try and future-proof this documentation by not getting into those details, directing readers to the canonical Excel documentation instead.

afeld · 2021-02-25T04:16:29Z

doc/source/getting_started/comparison/comparison_with_spreadsheets.rst

+        ],
+        index=["falcon", "parrot", "lion", "monkey", "leopard"],
+        columns=("class", "order", "max_speed"),
+    )


We have an outstanding task in #38990 around standardizing the example datasets used in the page. Totally fine to take care of that as follow-up; just noting.

afeld · 2021-02-25T04:27:55Z

Oh, one more thing:

Change "closes DOC: add comparison to spreadsheets #38990" to "part of DOC: add comparison to spreadsheets #38990" up top so the issue isn't automatically closed, since there will be remaining tasks

…eets.rst Co-authored-by: Aidan Feldman <[email protected]>

afeld

The outstanding comments still hold, but I think it's fine to take care of those as follow-ups. I don't have the ability to merge, but 👍 from me.

afeld · 2021-03-04T02:50:19Z

Also, the build failure seems unrelated to this change.

rhshadrach · 2021-03-27T16:22:28Z

doc/source/getting_started/comparison/comparison_with_spreadsheets.rst

+GroupBy
+-------
+
+In Excel, this can be done by using the `Query Editor <https://support.microsoft.com/en-us/office/introduction-to-the-query-editor-power-query-1d6cdb63-bf70-4ae8-a7d5-6ae9547004d9>`_.


This page says it will be retired soon, perhaps https://support.microsoft.com/en-us/office/about-power-query-in-excel-7104fbee-9e62-4cb9-a02e-5bfb1a6c536a is better.

rhshadrach

lgtm - can you merge master, I think it will resolve the CI issue.

rhshadrach · 2021-04-20T03:09:00Z

@Bhard27 - Are you interested in finishing this up? I think changes look good, can you merge master and will have another look.

0xpranjal · 2021-04-20T08:29:01Z

@Bhard27 - Are you interested in finishing this up? I think changes look good, can you merge master and will have another look.

Hey, I have pushed the changes you suggested. Is there anything else that needs to be done in this? Also, I don't have permission to merge this to master.

rhshadrach · 2021-04-21T04:40:14Z

@Bhard27 - yes, can you merge the master branch into your PR branch (happy to help with further instructions if you're unfamiliar with doing this, just let me know). We like to do this to run the CI on the most recent changes with master.

Also, I don't have permission to merge this to master.

Right, that needs to be done by a maintainer. Even maintainers shouldn't merge there own PRs ;)

github-actions · 2021-05-26T00:08:14Z

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

rhshadrach · 2021-05-26T03:10:00Z

@Bhard27 - friendly ping, are you interested in continuing this?

0xpranjal · 2021-06-06T11:35:12Z

@Bhard27 - friendly ping, are you interested in continuing this?

Sorry about the inactivity. I am a little confused about merging it with master branch because I think I already pushed it in the master branch.

rhshadrach · 2021-06-09T03:36:51Z

@Bhard27 I think what you've screenshot is the fact that you are doing a pull request from your branch into master. This branch was last updated on February 28th, and the tests that ran were based on what this patch (which hasn't changed) and master (which has changed) combined together. In general, we'd like to make sure the tests get run on a very recent copy of master, so the request here is to merge the master branch into this PR branch. Doing so will run the tests again on all the updated code.

To do this, run the command git merge upstream/master, then push to origin (your fork of the repo). In general you may have to resolve conflicts, but I don't believe that there will be any.

0xpranjal · 2021-06-13T19:03:04Z

@Bhard27 I think what you've screenshot is the fact that you are doing a pull request from your branch into master. This branch was last updated on February 28th, and the tests that ran were based on what this patch (which hasn't changed) and master (which has changed) combined together. In general, we'd like to make sure the tests get run on a very recent copy of master, so the request here is to merge the master branch into this PR branch. Doing so will run the tests again on all the updated code.

To do this, run the command git merge upstream/master, then push to origin (your fork of the repo). In general you may have to resolve conflicts, but I don't believe that there will be any.

Oh, Thanks a lot for the explanation. I totally understand why we need to merge it again and run the tests. I will do that ASAP

rhshadrach

Thanks for merging @Bhard27 - just the one outstanding request by @afeld. I think it would be good if the pandas example matched the excel example, but okay if it doesn't.

rhshadrach · 2021-06-23T00:53:01Z

doc/source/getting_started/comparison/comparison_with_spreadsheets.rst

+To aggregate a column, select the column to perform the Aggregate Operation on from the Column drop-down.
+A Row Operation does not require a Column, since data is grouped based on table rows.
+
+.. image:: ../../_static/spreadsheets/group-by.png


@Bhard27 Are you able to update the excel image to match the pandas example below?

rhshadrach · 2021-07-29T20:35:07Z

@Bhard27 - closing this as stale, but reply here if you are interested in continuing and can reopen.

0xpranjal added 3 commits February 22, 2021 11:47

Updated the comparison with spreadsheets with GroupBy

849df38

removed trailing whitespaces

24375f5

duplicate names removed

56fc085

jreback requested changes Feb 24, 2021

View reviewed changes

doc/source/getting_started/comparison/comparison_with_spreadsheets.rst Outdated Show resolved Hide resolved

doc/source/getting_started/comparison/comparison_with_spreadsheets.rst Outdated Show resolved Hide resolved

jreback added the Docs label Feb 24, 2021

jreback requested a review from afeld February 24, 2021 00:46

jreback added the IO Excel read_excel, to_excel label Feb 24, 2021

0xpranjal added 3 commits February 24, 2021 11:54

Changed the length same as the label

750e9fc

linkedin query editor docs and illustrated example

063f3c9

fixed pre commit error

94caaf7

afeld suggested changes Feb 25, 2021

View reviewed changes

0xpranjal and others added 4 commits February 28, 2021 23:57

Update doc/source/getting_started/comparison/comparison_with_spreadsh…

c1bec5c

…eets.rst Co-authored-by: Aidan Feldman <[email protected]>

updated docs based on the comments

d3bd0fe

Merge branch 'master' of https://github.com/Bhard27/pandas

ac228ca

Merge remote-tracking branch 'upstream/master'

be3b74b

0xpranjal requested a review from afeld February 28, 2021 20:55

0xpranjal added 5 commits March 1, 2021 02:31

small changes

0d64258

small changes

35de9ca

small changes

3b7cc6f

cli errors fixed

44a668d

cli errors fixed

227b85a

afeld approved these changes Mar 4, 2021

View reviewed changes

0xpranjal requested a review from jreback March 4, 2021 12:03

afeld mentioned this pull request Mar 13, 2021

HackIllinois 2021 Open Source Fellowship mentoring #39349

Closed

4 tasks

rhshadrach requested changes Mar 27, 2021

View reviewed changes

support document link changed

3f8c165

rhshadrach requested changes Mar 28, 2021

View reviewed changes

github-actions bot added the Stale label May 26, 2021

Merge branch 'pandas-dev:master' into master

7d1de9e

simonjayhawkins removed the Stale label Jun 16, 2021

rhshadrach requested changes Jun 23, 2021

View reviewed changes

rhshadrach closed this Jul 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DOC : Updated the comparison with spreadsheets with GroupBy #39965

DOC : Updated the comparison with spreadsheets with GroupBy #39965

0xpranjal commented Feb 22, 2021 •

edited

Loading

afeld left a comment

afeld Feb 25, 2021

rhshadrach Mar 28, 2021

rhshadrach May 26, 2021

rhshadrach Jun 23, 2021

afeld Feb 25, 2021

afeld Feb 25, 2021

afeld Feb 25, 2021

afeld commented Feb 25, 2021 •

edited

Loading

afeld left a comment

afeld commented Mar 4, 2021

rhshadrach Mar 27, 2021

0xpranjal Mar 28, 2021

rhshadrach left a comment

rhshadrach commented Apr 20, 2021

0xpranjal commented Apr 20, 2021

rhshadrach commented Apr 21, 2021

github-actions bot commented May 26, 2021

rhshadrach commented May 26, 2021

0xpranjal commented Jun 6, 2021

rhshadrach commented Jun 9, 2021 •

edited

Loading

0xpranjal commented Jun 13, 2021

rhshadrach left a comment

rhshadrach Jun 23, 2021

rhshadrach commented Jul 29, 2021

DOC : Updated the comparison with spreadsheets with GroupBy #39965

DOC : Updated the comparison with spreadsheets with GroupBy #39965

Conversation

0xpranjal commented Feb 22, 2021 • edited Loading

afeld left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afeld commented Feb 25, 2021 • edited Loading

afeld left a comment

Choose a reason for hiding this comment

afeld commented Mar 4, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhshadrach left a comment

Choose a reason for hiding this comment

rhshadrach commented Apr 20, 2021

0xpranjal commented Apr 20, 2021

rhshadrach commented Apr 21, 2021

github-actions bot commented May 26, 2021

rhshadrach commented May 26, 2021

0xpranjal commented Jun 6, 2021

rhshadrach commented Jun 9, 2021 • edited Loading

0xpranjal commented Jun 13, 2021

rhshadrach left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhshadrach commented Jul 29, 2021

0xpranjal commented Feb 22, 2021 •

edited

Loading

afeld commented Feb 25, 2021 •

edited

Loading

rhshadrach commented Jun 9, 2021 •

edited

Loading