CLN: Remove some duplicated tests and parametrize #39960
Conversation
phofl
added
Clean
Indexing
pandas/tests/indexing/test_iloc.py
Outdated
| @@ -35,28 +35,12 @@ | |||
|
|
|||
|
|
|||
| class TestiLoc(Base): | |||
| def test_iloc_getitem_int(self): | |||
| @pytest.mark.parametrize("key", [2, -1, [0, 1, 2]]) | |||
| def test_iloc_getitem_int(self, key): | |||
There was a problem hiding this comment.
rename since it is no longer just int keys?
pandas/tests/indexing/test_loc.py
Outdated
| @@ -762,7 +756,8 @@ def test_loc_coercion(self): | |||
| result = df.iloc[3:] | |||
| tm.assert_series_equal(result.dtypes, expected) | |||
|
|
|||
| def test_setitem_new_key_tz(self): | |||
| @pytest.mark.parametrize("indexer", [tm.setitem, tm.loc]) | |||
There was a problem hiding this comment.
fixture for this is indexer_sl
pandas/tests/indexing/test_loc.py
Outdated
| timedelta_range(start="1 day", end="2 days", freq="1H"), | ||
| ], | ||
| ) | ||
| def test_loc_getitem_label_slice_period(self, ix): |
There was a problem hiding this comment.
rename to not period-specific?
is there a corresponding dt64 test that should be rolled into this?
call it index instead of ix?
| @@ -507,30 +507,22 @@ def test_floating_misc(self): | |||
| # label based slicing | |||
| result1 = s[1.0:3.0] | |||
| result2 = s.loc[1.0:3.0] | |||
| result3 = s.loc[1.0:3.0] | |||
There was a problem hiding this comment.
not necessarily for this PR, but i think this test can be parametrized over indexer_sl
There was a problem hiding this comment.
Yes, good point. Was too focused on the duplicates :)
pandas/tests/indexing/test_floats.py
Outdated
| @@ -498,122 +498,72 @@ def test_floating_index_doc_example(self): | |||
| assert s.loc[3] == 2 | |||
| assert s.iloc[3] == 3 | |||
|
|
|||
| def test_floating_misc(self): | |||
| @pytest.mark.parametrize("indexer_sl", [tm.getitem, tm.loc]) | |||
There was a problem hiding this comment.
you dont need to parametrize since indexer_sl is a fixture
pandas/tests/indexing/test_loc.py
Outdated
| @@ -762,7 +756,8 @@ def test_loc_coercion(self): | |||
| result = df.iloc[3:] | |||
| tm.assert_series_equal(result.dtypes, expected) | |||
|
|
|||
| def test_setitem_new_key_tz(self): | |||
| @pytest.mark.parametrize("indexer_sl", [tm.setitem, tm.loc]) | |||
There was a problem hiding this comment.
ditto, indexer_sl is a fixture
|
couple comments, ping on green |
|
ping @jbrockmendel green |
|
thanks @phofl |
There were a few duplicates from the ix removal