REF: implement array_algos.take #39948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Feb 21, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
if you can rebase |
|
rebased + green |
|
maybe just more all of algorithms.py to array_algos? though i think these should probably be in somewhat separated modules rather than one giant one. so ok with moveing take but let's put it separate as its pretty meaty by itself. |
there are some that depend on Index/Series, so they dont all fit |
jreback
reviewed
Feb 23, 2021
|
|
||
| return func2 | ||
|
|
||
|
|
||
| def take( |
There was a problem hiding this comment.
how are we not moving this?
There was a problem hiding this comment.
its high-level and i dont want to futz with updating imports everywhere else
|
k thanks |
| if fill_value is lib.no_default: | ||
| fill_value = na_value_for_dtype(arr.dtype, compat=False) | ||
|
|
||
| arr = extract_array(arr, extract_numpy=True) |
There was a problem hiding this comment.
"array algos" should only deal with arrays IMO
There was a problem hiding this comment.
good catch, will fix in follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.