Skip to content

BUG: Breaking change to offsets.pyx - MonthOffset #39887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 71 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
a944a27
Update offsets.pyx
Pawel-Kranzberg Feb 17, 2021
fb439fc
Merge remote-tracking branch 'upstream/master'
Pawel-Kranzberg Feb 17, 2021
87e1b87
Update offsets.pyx
Pawel-Kranzberg Feb 17, 2021
5d46697
Update offsets.pyx
Pawel-Kranzberg Feb 17, 2021
a583905
Update offsets.pyx
Pawel-Kranzberg Feb 17, 2021
cd216ae
Update offsets.pyx
Pawel-Kranzberg Feb 17, 2021
53b09c1
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
6fdb0af
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
b7d671b
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
de72073
Add ability to provide months as short names
Pawel-Kranzberg Feb 18, 2021
bfaf6ce
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
1b396dd
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
d7f7020
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
ca67f8a
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
e04e27d
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
d4d87c4
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
2c22a31
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
11cb0b5
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
71e9cab
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
29edef3
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
485e60b
[BUG] Breaking change to offsets.pyx - MonthOffset
Pawel-Kranzberg Feb 18, 2021
0fa3644
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
3456f5a
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
564cd29
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
926745d
Update offsets.pyx
Pawel-Kranzberg Feb 18, 2021
4593d72
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
85c896c
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
6654c89
Update test_asfreq.py
Pawel-Kranzberg Feb 20, 2021
527f70f
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
32d61ed
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
63325a0
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
199237a
Update dtypes.pyx
Pawel-Kranzberg Feb 20, 2021
cd79bff
Update test_asfreq.py
Pawel-Kranzberg Feb 20, 2021
42c4e26
Update test_asfreq.py
Pawel-Kranzberg Feb 20, 2021
0ce8c02
Update test_asfreq.py
Pawel-Kranzberg Feb 20, 2021
362d3d1
Update test_asfreq.py
Pawel-Kranzberg Feb 20, 2021
6f18722
Update test_period.py
Pawel-Kranzberg Feb 20, 2021
818cbdf
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
1d14b0f
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
700ba0e
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
648c7a8
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
fdc7e54
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
070cd72
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
efb314e
Update offsets.pyx
Pawel-Kranzberg Feb 20, 2021
045177e
Update offsets.pyx
Pawel-Kranzberg Feb 21, 2021
4f15b5b
Update offsets.pyx
Pawel-Kranzberg Feb 21, 2021
fbf3f68
Update offsets.pyx
Pawel-Kranzberg Feb 21, 2021
5f8711c
Update dtypes.pyx
Pawel-Kranzberg Mar 17, 2021
a804a3e
Update test_asfreq.py
Pawel-Kranzberg Mar 17, 2021
213fb66
fix formatting
Pawel-Kranzberg Mar 17, 2021
50ddb86
Update test_asfreq.py
Pawel-Kranzberg Mar 18, 2021
2acbd33
Fixed "MS" code mapping in _period_code_map
Pawel-Kranzberg Mar 25, 2021
6c53c39
Merge remote-tracking branch 'upstream/master'
Pawel-Kranzberg Mar 25, 2021
73f698a
Merge branch 'master' into patch-1
Pawel-Kranzberg Mar 25, 2021
407850c
Add PeriodDtypeCode to MonthBegin
Pawel-Kranzberg Mar 25, 2021
7bae3f5
Update offsets.pyx
Pawel-Kranzberg Mar 25, 2021
1c1fd3a
Fix MonthBegin PeriodDtypeCode
Pawel-Kranzberg Mar 25, 2021
e519610
Bug hunt
Pawel-Kranzberg Mar 25, 2021
c5a69b2
Remove double BusinessMonthBegin
Pawel-Kranzberg Mar 25, 2021
c618bfc
Merge pull request #1 from pandas-dev/master
Pawel-Kranzberg Mar 30, 2021
b114ff9
Merge pull request #4 from pandas-dev/master
Pawel-Kranzberg Mar 30, 2021
0628d22
Coverage bug hunt
Pawel-Kranzberg Mar 30, 2021
ff98362
Revert "Coverage bug hunt"
Pawel-Kranzberg Mar 30, 2021
56be0c9
Bug hunt
Pawel-Kranzberg Mar 30, 2021
5303ff9
Revert "Bug hunt"
Pawel-Kranzberg Mar 30, 2021
8aa0d8f
retrigger checks
Pawel-Kranzberg Apr 23, 2021
cfa2972
Update v1.3.0.rst
Pawel-Kranzberg Apr 23, 2021
045365f
Merge branch 'master' into patch-1
Pawel-Kranzberg Apr 23, 2021
118f422
Update v1.3.0.rst
Pawel-Kranzberg Apr 23, 2021
8da61dc
retrigger checks
Pawel-Kranzberg Apr 25, 2021
0ebf77b
Merge branch 'patch-1' of https://github.com/Pawel-Kranzberg/pandas i…
Pawel-Kranzberg Apr 25, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pandas/_libs/tslibs/offsets.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -2156,6 +2156,8 @@ cdef class QuarterBegin(QuarterOffset):
# Month-Based Offset Classes

cdef class MonthOffset(SingleConstructorOffset):
_period_dtype_code = PeriodDtypeCode.M

def is_on_offset(self, dt: datetime) -> bool:
if self.normalize and not _is_normalized(dt):
return False
Expand Down Expand Up @@ -2189,7 +2191,6 @@ cdef class MonthEnd(MonthOffset):
"""
DateOffset of one month end.
"""
_period_dtype_code = PeriodDtypeCode.M
_prefix = "M"
_day_opt = "end"

Expand Down