CLN: remove redundant code related to Styler #39884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attack68
changed the title
|
Nice. IIRC non_reducing_slice is only used in this file, would it make sense to move it there? |
Yes I observed the same but was bigger change. updated now. |
jreback
added
Refactor
|
thanks @attack68 would you mind doing a PR splitting up test_style.py (you can create a sub-dir and put in several tests modules) as its getting kind of long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non_reducing_sliceis performed within theapplyso no need to execute twice.maybe_numeric_sliceis a convoluted wrapper for selecting numeric columns so removed.