Skip to content

TYP: typing refactor mypy fix #39812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Conversation

attack68
Copy link
Contributor

pandas/io/formats/style.py:168: error: Incompatible types in assignment (expression has type "Union[DataFrame, Series]", variable has type "DataFrame") [assignment]

refactor to remove the assert statement otherwise needed to solve the above mypy error.

@attack68 attack68 changed the title CLN: typing refactor mypy fix TYP: typing refactor mypy fix Feb 14, 2021
@jbrockmendel
Copy link
Member

LGTM cc @simonjayhawkins

@lithomas1 lithomas1 added the Typing type annotations, mypy/pyright type checking label Feb 15, 2021
@lithomas1 lithomas1 added this to the 1.3 milestone Feb 15, 2021
@jreback jreback merged commit 52d9bb9 into pandas-dev:master Feb 15, 2021
@jreback
Copy link
Contributor

jreback commented Feb 15, 2021

thanks @attack68

@attack68 attack68 deleted the refector_type branch February 15, 2021 17:23
@attack68 attack68 added the Styler conditional formatting using DataFrame.style label Feb 16, 2021
znicholls pushed a commit to znicholls/pandas that referenced this pull request Feb 17, 2021
Co-authored-by: JHM Darbyshire (MBP) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Styler conditional formatting using DataFrame.style Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants